Skip to content

Comments

Added a button for displaying the YaST logs#407

Merged
lslezak merged 9 commits intomasterfrom
show_logs
Feb 6, 2023
Merged

Added a button for displaying the YaST logs#407
lslezak merged 9 commits intomasterfrom
show_logs

Conversation

@lslezak
Copy link
Contributor

@lslezak lslezak commented Jan 24, 2023

Problem

Solution

  • Added a new button which opens a popup with the y2log file
  • So far a simple solution, no message colorizing or filtering. We can improve it later.

Testing

  • Tested manually

TODO

  • Unit tests

Screenshots

Options Menu Log Popup
log_view_button log_view_popup

logs-loading

@coveralls
Copy link

coveralls commented Jan 24, 2023

Coverage Status

Coverage: 76.831%. Remained the same when pulling c4caae7 on show_logs into a28b018 on master.

Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lslezak!

The approach looks good and simple as a first step for having an easy way to check the logs. However, I have left a few suggestions, please check them before going for the unit testing.

Thanks!

@lslezak lslezak marked this pull request as ready for review February 6, 2023 09:35
Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a few comments

Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@lslezak lslezak merged commit f605a5d into master Feb 6, 2023
@lslezak lslezak deleted the show_logs branch February 6, 2023 13:40
@lslezak lslezak mentioned this pull request Feb 7, 2023
5 tasks
@imobachgs imobachgs mentioned this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants