yupdate - allow building the web frontend in the development mode#404
Merged
yupdate - allow building the web frontend in the development mode#404
Conversation
dgdavid
approved these changes
Jan 20, 2023
Contributor
dgdavid
left a comment
dgdavid
left a comment
There was a problem hiding this comment.
Looks good, just an idea commented there. Thank you!
Comment on lines
+121
to
+129
| # clean up the extra files when switching the development/production mode | ||
| if node_env == "production" | ||
| # remove the uncompressed and development files | ||
| FileUtils.rm_f(Dir.glob("/usr/share/cockpit/d-installer/index.{css,html,js}")) | ||
| FileUtils.rm_f(Dir.glob("/usr/share/cockpit/d-installer/*.map")) | ||
| else | ||
| # remove the compressed files | ||
| FileUtils.rm_f(Dir.glob("/usr/share/cockpit/d-installer/*.gz")) | ||
| end |
Contributor
There was a problem hiding this comment.
NP: Why not just removing the full content before running the make install?
Anyway, it looks good, thanks.
Contributor
Author
There was a problem hiding this comment.
If make install failed you would have empty directory, i.e. no d-installer at all, this is safer.
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
yupdatescript builds the web frontend in the production mode. That has some disadvantages:*.map) are missing, you cannot get a reference to the original sources, this makes debugging more difficultSolution
NODE_ENVvalue from the current environmentTesting
NODE_ENV=development yupdate ...