Merged
Conversation
By setting layout as realtive positioning, which makes it the sidebar closest positioned ancestor. * https://www.w3.org/TR/css-position-3/#valdef-position-relative * https://developer.mozilla.org/en-US/docs/Web/CSS/position
Introduced in f5775f4
It affects to last-child/margin-block-end now, which helps to exclude the legend element too. Reasoning: using the first-child/margin-block-start makes not possible (ATM, at least) to avoid adding the margin at the first-child which is not a legend in a fieldset.
Unfortunately, some relatively "recents" versions of major browsers do not support "Small, Large, and Dynamic viewport units" yet. * https://www.w3.org/TR/css-values-4/#viewport-variants * https://caniuse.com/?search=dvb
In commit f9e0437 a browser complain was fixed by importing the fonts.scss in the src/index.js file to allow webpack to follow the fonts urls and place them in dist/fonts. Later, commit 5cf689d dropped the `@use "@assets/styles/fonts.scss"` at-rule from the styles/index.scss file for considering it kind of redundant. And finally, the fonts.scss file was renamed to fonts.css in c0a64af because it was no longer needed to preprocess it with Sass due to the mentioned changes. All the above led to the situation in which fonts were available at dist/fonts but the browser were not loading the fonts.css file and, consequently, not loading the fonts (this time, silently, without complaining). To fix it once and for all, the following changes have been applied: * Rename back the file to fonts.scss to be able to import it with the @use at-rule from styles/index.scss. * Remove the specific rule for the fonts.scss file from webpack.config.js and, instead * -- Stop excluding it from the genral (s)css webpack rule * -- Change the css-loader's url option to a filter to tell webpack to only follow urls including "./fonts/" * -- Move assets/fonts to assets/styles/fonts for making webpack able to follow the url.
dgdavid
force-pushed
the
css-adjustments
branch
from
01f8c30 to
daf4a43
Compare
imobachgs
approved these changes
Jan 22, 2023
Merged
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Feb 16, 2023
https://build.opensuse.org/request/show/1066106 by user IGonzalezSosa + dimstar_suse - Version 0.7 - Do not use a proxy to get the errors lists (gh#agama-project/agama#424). - Add live reloading feature for easing the front-end development process (gh#agama-project/agama#419). - Fix storage section crashing when proposal is not ready (gh#agama-project/agama#418). - Better handling of software repositories (gh#agama-project/agama#414): * Report issues when reading the software repositories. * Inform the user about the software proposal progress. * Add a button to reload the repositories (gh#agama-project/agama#388). - Added a button for displaying the YaST logs (related to gh#agama-project/agama#379) - UI fixes (gh#agama-project/agama#401): * Add a fallback height for the layout * Fix some miss-alignments * Add missing icon * Ensure tooling serving and loading fo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a
height: 100vhfallback for the layout since Chromium < 108 browsers do not support the Dynamic viewport units.Click to show/hide screenshots
Fix fieldset legend missalignment introduced in f5775f4
Click to show/hide screenshots
Use the .stack CSS class for fieldsets by default. It creates a good flow between elements.
Click to show/hide screenshots
Fix sidebar position by setting layout as relative positioning (forgotten in 0661e10)
Click to show/hide screenshots
Fix missing software section icon. It was using a former
iconprop for a section instead of the newiconName.Click to show/hide screenshots
Fix the fonts loading once more.
No screenshots available, just read the commit description addcac7