[web] Fix "font: download failed" complain#385
Merged
Conversation
imobachgs
approved these changes
Jan 2, 2023
dgdavid
added a commit
that referenced
this pull request
Jan 11, 2023
Since we're using an specific rule in webpack.config.js file for fonts, we can't rely on @use Sass at-rule for importing the fonts.scss file. Instead, we have to import it in the index.js file directly, for making webpack aware of it. What is more, most probably the fonts.scss file could be renamed to fonts.css since it does not contain nothing to process with Sass. Related to #385
dgdavid
added a commit
that referenced
this pull request
Jan 11, 2023
Since we're using an specific rule in webpack.config.js file for fonts, we can't rely on @use Sass at-rule for importing the fonts.scss file. Instead, we have to import it in the index.js file directly, for making webpack aware of it. What is more, most probably the fonts.scss file could be renamed to fonts.css since it does not contain nothing to process with Sass. Related to #385
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Custom fonts are not being included in the final bundle, as expected. Most probably, current webpack configuration is not able to understand the Sass @use at rule as an import and thus is not applying the custom configuration for the fonts.scss file
Solution
Explicitly import the fonts.scss file for ensuring build contains the desired fonts to be downloaded when needed.
Testing
Manually tested.