Skip to content

Implement the ImportGpgKey callback#371

Merged
imobachgs merged 4 commits intomasterfrom
import-gpg-key
Dec 15, 2022
Merged

Implement the ImportGpgKey callback#371
imobachgs merged 4 commits intomasterfrom
import-gpg-key

Conversation

@imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Dec 15, 2022

Problem

Although users are not expected to use their own repositories at this time, it is not uncommon that we need to try some package that lives in a development repository in OBS. In those cases, you might need to import the GPG key.

Solution

This PR implements support to ask the user about importing a GPG key. The presentation could be improved, but let's do that after December's prototype.

Testing

  • Added a new unit test
  • Tested manually

Screenshots

libzypp-callbacks-import-pgp-key

@coveralls
Copy link

coveralls commented Dec 15, 2022

Coverage Status

Coverage increased (+0.04%) to 76.149% when pulling 182fc01 on import-gpg-key into 2a23b4f on master.

@imobachgs imobachgs force-pushed the import-gpg-key branch 2 times, most recently from e02477f to 182fc01 Compare December 15, 2022 13:39
@imobachgs imobachgs marked this pull request as ready for review December 15, 2022 13:40
Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants