Conversation
imobachgs
force-pushed
the
add-software-callbacks
branch
from
6238c82 to
ec18d63
Compare
* Only implement the AcceptUnsignedFile callback.
imobachgs
force-pushed
the
add-software-callbacks
branch
5 times, most recently
from
3e6e3b4 to
3c4c6c9
Compare
imobachgs
force-pushed
the
add-software-callbacks
branch
2 times, most recently
from
d3dbf90 to
88f56c0
Compare
imobachgs
force-pushed
the
add-software-callbacks
branch
from
88f56c0 to
57532d0
Compare
* It might happen that we skip a package installation. In that case, the progress is not updated. By now, let's just force to finish the progress.
imobachgs
force-pushed
the
add-software-callbacks
branch
from
b2bd836 to
2c77cd0
Compare
dgdavid
approved these changes
Dec 15, 2022
Contributor
dgdavid
left a comment
dgdavid
left a comment
There was a problem hiding this comment.
LGTM, just a minor comment.
joseivanlopez
approved these changes
Dec 15, 2022
| error, options: [:Retry, :Skip], default_option: :Retry | ||
| ) | ||
| ask(question) do |q| | ||
| logger.info "#{q.text}: #{q.answer}" |
Contributor
There was a problem hiding this comment.
NP: Maybe #ask should always log this.
Contributor
Author
There was a problem hiding this comment.
You are right. I will make a note to change that in another PR (we do the same in the storage callbacks).
joseivanlopez
approved these changes
Dec 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When something goes wrong during packages installation, the user is not informed.
Solution
Implement a few
libzyppcallbacks to inform the user about potential problems.Testing
To do