Skip to content

Change labels (and aria label) for extra option buttons #3166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ancorgs merged 3 commits into from
Feb 13, 2026
Merged

Change labels (and aria label) for extra option buttons #3166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b2679f
web: Change label
ancorgs Feb 13, 2026
f975b1b
web: Align labels (and aria labels) of similar menus
ancorgs Feb 13, 2026
68afa9e
Changelog
ancorgs Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions web/package/agama-web-ui.changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
-------------------------------------------------------------------
Fri Feb 13 09:25:56 UTC 2026 - Ancor Gonzalez Sosa <ancor@suse.com>

- Change the label of the button for extra storage options (related
to gh#agama-project/agama#3092 and bsc#1258089).

-------------------------------------------------------------------
Thu Feb 12 14:38:38 UTC 2026 - Imobach Gonzalez Sosa <igonzalezsosa@suse.com>

Expand Down
5 changes: 3 additions & 2 deletions web/src/components/core/InstallerOptionsMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,14 @@ export default function InstallerOptionsMenu({
<MenuToggle
ref={toggleRef}
onClick={toggle}
aria-label={_("Options toggle")}
// TRANSLATORS: this is an ARIA (accesibility) description of an UI element
aria-label={_("More installer options")}
isExpanded={isOpen}
isFullHeight
variant="plain"
>
<Flex gap={{ default: "gapXs" }} alignItems={{ default: "alignItemsCenter" }}>
{!hideLabel && _("Options")} <Icon name="expand_circle_down" />
{!hideLabel && _("More")} <Icon name="expand_circle_down" />
</Flex>
</MenuToggle>
)}
Expand Down
2 changes: 1 addition & 1 deletion web/src/components/storage/ConnectedDevicesMenu.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ async function openMenu() {

it("renders the menu", () => {
const { container } = installerRender(<ConnectedDevicesMenu />);
screen.getByText("Options");
screen.getByText("More");
const icon = container.querySelector("svg");
expect(icon).toHaveAttribute("data-icon-name", "arrow_drop_down");
});
Expand Down
2 changes: 1 addition & 1 deletion web/src/components/storage/ConnectedDevicesMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export default function ConnectedDevicesMenu() {
</MenuButton.Item>,
]}
>
{_("Options")} <Icon name="arrow_drop_down" className="agm-three-dots-icon" />
{_("More")} <Icon name="arrow_drop_down" className="agm-three-dots-icon" />
</MenuButton>
);
}