Skip to content

Only show the link for connecting to a WiFI network if wireless is enabled#316

Merged
imobachgs merged 8 commits intomasterfrom
wifi_enabled
Dec 15, 2022
Merged

Only show the link for connecting to a WiFI network if wireless is enabled#316
imobachgs merged 8 commits intomasterfrom
wifi_enabled

Conversation

@teclator
Copy link
Contributor

@teclator teclator commented Nov 17, 2022 •
edited
Loading

Problem

In #292 we added support for configuring a WiFi connection but it shows the link to connect to a network even when wireless is currently not enabled which is not correct at all.

Solution

Do not show the link to connect to a Wireless when it is not enabled.

Testing

  • Added unit test for the backend, the Network.jsx component still lacks of it as there is some problem with the useEffect and maybe waitFor with a callback needs to be added.
  • Tested manually

Screenshots

Wireless Enabled Wireless Disabled
localhost_9090_cockpit_@localhost_d-installer_index html (9) localhost_9090_cockpit_@localhost_d-installer_index html (10)

D-Installer_NetworkSettings

@teclator teclator force-pushed the wifi_enabled branch 3 times, most recently from 21ae657 to e5ff264 Compare November 18, 2022 08:15
@imobachgs imobachgs linked an issue Nov 21, 2022 that may be closed by this pull request
Show the link to set up a wireless connection even if there is no network #323
Closed
@teclator teclator force-pushed the wifi_enabled branch 3 times, most recently from ebc8be8 to a015278 Compare December 15, 2022 10:18
@dgdavid dgdavid self-requested a review December 15, 2022 10:25
@coveralls
Copy link

coveralls commented Dec 15, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 76.067% when pulling c903775 on wifi_enabled into 91dc744 on master.

dgdavid
dgdavid reviewed Dec 15, 2022
View reviewed changes
dgdavid
dgdavid approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@imobachgs imobachgs merged commit f6ce57b into master Dec 15, 2022
@imobachgs imobachgs deleted the wifi_enabled branch December 15, 2022 13:54
@imobachgs imobachgs mentioned this pull request Dec 15, 2022
Merged
@teclator teclator mentioned this pull request Dec 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgdavid dgdavid dgdavid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Show the link to set up a wireless connection even if there is no network

4 participants

@teclator @coveralls @dgdavid @imobachgs