Skip to content

Sort products alphabetically #3145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imobachgs merged 3 commits into from
Feb 11, 2026
Merged

Sort products alphabetically #3145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1cff72
Sort products alphabetically
imobachgs Feb 11, 2026
8c4fa77
Update changes file
imobachgs Feb 11, 2026
fc28cc7
Merge branch 'master' into sorted-products
imobachgs Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions rust/agama-utils/src/products.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,8 @@ impl Registry {

/// Returns a vector with available the products
pub fn products(&self) -> Vec<Product> {
self.products
let mut products: Vec<_> = self
.products
.iter()
.map(|p| {
let modes = p
Expand All @@ -176,7 +177,10 @@ impl Registry {
modes,
}
})
.collect()
.collect();

products.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase()));
Copy link
Copy Markdown
Contributor

@lslezak lslezak Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that sort according to the current locale or is it a plain sort (C-like locale)?

Copy link
Copy Markdown
Contributor Author

@imobachgs imobachgs Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plain unicode. We are just ordering the product names, so I would expect that to be enough.

products
}
}

Expand Down
5 changes: 5 additions & 0 deletions rust/package/agama.changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
-------------------------------------------------------------------
Wed Feb 11 13:48:37 UTC 2026 - Imobach Gonzalez Sosa <igonzalezsosa@suse.com>

- Sort the list of products alphabetically (gh#agama-project/agama#3145).

-------------------------------------------------------------------
Wed Feb 11 13:34:36 UTC 2026 - Ladislav Slezák <lslezak@suse.com>

Expand Down
Loading