refactor(web): restore interface for managing DASD from web client

rust/agama-lib/share/README.md

@@ -10,6 +10,7 @@ The Agama autoinstallation profile JSON schema is defined in these files:
 - [profile.schema.json](./profile.schema.json) (the main definition)
 - [storage.schema.json](./storage.schema.json) (referenced from the main definition)
 - [iscsi.schema.json](./iscsi.schema.json) (referenced from the main definition)
+- [dasd.schema.json](./dasd.schema.json) (referenced from the main definition)
 
 ## Agama REST API
 

rust/agama-lib/share/dasd.schema.json

@@ -0,0 +1,41 @@
+{
+  "$schema": "https://json-schema.org/draft/2019-09/schema",
+  "$id": "https://github.com/agama-project/agama/blob/master/rust/agama-lib/share/dasd.schema.json",
+  "title": "Config",
+  "description": "DASD config.",
+  "type": "object",
+  "additionalProperties": false,
+  "properties": {
+    "devices": {
+      "description": "List of DASD devices.",
+      "type": "array",
+      "items": { "$ref": "#/$defs/device" }
+    }
+  },
+  "$defs": {
+    "device": {
+      "type": "object",
+      "additionalProperties": false,
+      "required": ["channel"],
+      "properties": {
+        "channel": {
+          "description": "DASD device channel.",
+          "type": "string"
+        },
+        "state": {
+          "description": "Specify target state of device. Either activate it or deactivate it.",
+          "enum": ["active", "offline"],
+          "default": "active"
+        },
+        "format": {
+          "description": "If device should be formatted. If not specified then it format device only if not already formatted.",
+          "type": "boolean"
+        },
+        "diag": {
+          "description": "If device have set diag flag. If not specified then it keep what device has before.",
+          "type": "boolean"
+        }
+      }
+    }
+  }
+}

rust/agama-lib/share/package.json

@@ -1,6 +1,6 @@
 {
   "scripts": {
-    "validate": "ajv compile --spec=draft2019 --verbose --all-errors -r storage.schema.json -r iscsi.schema.json -r software.schema.json -s profile.schema.json && ajv compile --spec=draft2019 --verbose --all-errors -s storage.model.schema.json"
+    "validate": "ajv compile --spec=draft2019 --verbose --all-errors -r storage.schema.json -r iscsi.schema.json -r dasd.schema.json -r software.schema.json -s profile.schema.json && ajv compile --spec=draft2019 --verbose --all-errors -s storage.model.schema.json"
   },
   "dependencies": {
     "ajv-cli": "^5.0.0"

rust/agama-lib/share/profile.schema.json

@@ -98,40 +98,7 @@
         }
       ]
     },
-    "dasd": {
-      "title": "DASD device activation (s390x only)",
-      "type": "object",
-      "properties": {
-        "devices": {
-          "title": "List of DASD devices",
-          "type": "array",
-          "items": {
-            "type": "object",
-            "properties": {
-              "channel": {
-                "title": "DASD device channel",
-                "type": "string"
-              },
-              "state": {
-                "title": "Specify target state of device. Either activate it or deactivate it.",
-                "type": "string",
-                "enum": ["active", "offline"],
-                "default": "active"
-              },
-              "format": {
-                "title": "If device should be formatted. If not specified then it format device only if not already formatted.",
-                "type": "boolean"
-              },
-              "diag": {
-                "title": "If device have set diag flag. If not specified then it keep what device has before.",
-                "type": "boolean"
-              }
-            },
-            "required": ["channel"]
-          }
-        }
-      }
-    },
+    "dasd": { "$ref": "dasd.schema.json" },
     "zfcp": {
       "title": "zFCP device activation (s390x only)",
       "type": "object",

rust/package/agama.changes

@@ -1,3 +1,8 @@
+-------------------------------------------------------------------
+Thu Feb 26 16:44:32 UTC 2026 - David Diaz <dgonzalez@suse.com>
+
+- Add schema for DASD config (gh#agama-project/agama#3143).
+
 -------------------------------------------------------------------
 Wed Feb 25 08:13:55 UTC 2026 - Josef Reidinger <jreidinger@suse.com>
 

rust/package/agama.spec

@@ -255,6 +255,7 @@ echo $PATH
 %dir %{_datadir}/agama/jsonnet
 %{_datadir}/agama/jsonnet/agama.libsonnet
 %dir %{_datadir}/agama/schema
+%{_datadir}/agama/schema/dasd.schema.json
 %{_datadir}/agama/schema/iscsi.schema.json
 %{_datadir}/agama/schema/profile.schema.json
 %{_datadir}/agama/schema/software.schema.json

rust/share/system.dasd.schema.json

@@ -1,6 +1,6 @@
 {
   "$schema": "https://json-schema.org/draft/2019-09/schema",
-  "$id": "https://github.com/openSUSE/agama/blob/master/rust/share/system.storage.schema.json",
+  "$id": "https://github.com/openSUSE/agama/blob/master/rust/share/system.dasd.schema.json",
   "title": "System",
   "description": "API description of the DASD system",
   "type": "object",

service/lib/agama/dbus/storage/dasd.rb

@@ -144,7 +144,7 @@ def device_json(dasd)
             type:          manager.device_type(dasd),
             diag:          dasd.use_diag,
             accessType:    dasd.access_type || "",
-            partitionInfo: dasd.partition_info || "",
+            partitionInfo: dasd.offline? ? "" : dasd.partition_info.to_s,
             status:        dasd.status.to_s,
             active:        !dasd.offline?,
             formatted:     dasd.formatted?

service/lib/agama/storage/dasd/enable_operation.rb

@@ -30,6 +30,9 @@ class EnableOperation < SequentialOperation
       private
 
         def process_dasd(dasd)
+          # Reset #diag_wanted, otherwise the device cannot be enabled again if a {DiagOperation}
+          # for enabling diag failed.
+          dasd.diag_wanted = dasd.use_diag
           # We considered to stop using dasd_configure in favor of directly calling "chzdev -e".
           # That would allow us, for example, to enable all the devices with a single command.
           # But dasd_configure does a couple of extra things we still find valuable:

service/package/rubygem-agama-yast.changes

@@ -1,3 +1,9 @@
+-------------------------------------------------------------------
+Thu Feb 26 16:47:39 UTC 2026 - David Diaz <dgonzalez@suse.com>
+
+- Allow reactivating a DASD if enabling DIAG failed
+  (gh#agama-project/agama#3143).
+
 -------------------------------------------------------------------
 Wed Feb 18 20:28:02 UTC 2026 - Josef Reidinger <jreidinger@suse.com>
 

web/package/agama-web-ui.changes

@@ -1,3 +1,9 @@
+-------------------------------------------------------------------
+Thu Feb 26 16:43:44 UTC 2026 - David Diaz <dgonzalez@suse.com>
+
+- Restore the interface for managing DASD in the web client
+  (gh#agama-project/agama#3143).
+
 -------------------------------------------------------------------
 Fri Feb 20 15:00:44 UTC 2026 - Imobach Gonzalez Sosa <igonzalezsosa@suse.com>
 

web/src/App.tsx

@@ -25,7 +25,7 @@ import { Outlet, useLocation } from "react-router";
 import { useStatusChanges, useStatus } from "~/hooks/model/status";
 import { useSystemChanges } from "~/hooks/model/system";
 import { useProposal, useProposalChanges } from "~/hooks/model/proposal";
-import { useIssuesChanges } from "~/hooks/model/issue";
+import { useIssues, useIssuesChanges } from "~/hooks/model/issue";
 import { useProductInfo } from "~/hooks/model/config/product";
 import { useQueryClient } from "@tanstack/react-query";
 import { InstallationFinished, InstallationProgress } from "./components/core";
@@ -44,6 +44,7 @@ const Content = () => {
   //
   // https://tanstack.com/query/latest/docs/framework/react/guides/query-invalidation
   useProposal();
+  useIssues();
 
   const location = useLocation();
   const product = useProductInfo();

web/src/api.ts

@@ -30,7 +30,6 @@ import type { Status } from "~/model/status";
 import type { System } from "~/model/system";
 import type { Action, L10nSystemConfig, DiscoverISCSIConfig } from "~/model/action";
 import type { AxiosResponse } from "axios";
-import type { Job } from "~/types/job";
 
 type Response = Promise<AxiosResponse>;
 
@@ -82,11 +81,6 @@ const discoverISCSIAction = (config: DiscoverISCSIConfig) => postAction({ discov
 
 const finishInstallation = () => postAction({ finish: "reboot" });
 
-/**
- * @todo Adapt jobs to the new API.
- */
-const getStorageJobs = (): Promise<Job[]> => get("/api/storage/jobs");
-
 export {
   getStatus,
   getConfig,
@@ -106,7 +100,6 @@ export {
   probeStorageAction,
   discoverISCSIAction,
   finishInstallation,
-  getStorageJobs,
 };
 
 export type { Response };

web/src/components/core/SelectableDataTable.test.tsx

@@ -220,6 +220,21 @@ describe("SelectableDataTable", () => {
     expect(editFn).toHaveBeenCalled();
   });
 
+  it("uses itemActionsComponent when provided instead of the default ActionsColumn", async () => {
+    const CustomActions = ({ label }) => <span>Custom actions: {label}</span>;
+
+    plainRender(
+      <SelectableDataTable
+        {...props}
+        itemActions={(d) => [{ title: `Edit ${d.name}`, onClick: jest.fn() }]}
+        itemActionsLabel={(d) => `Actions for ${d.name}`}
+        itemActionsComponent={CustomActions}
+      />,
+    );
+
+    screen.getByText("Custom actions: Actions for /dev/sda");
+  });
+
   it("renders a expand toggler in items with children", () => {
     plainRender(<SelectableDataTable {...props} />);
     const table = screen.getByRole("grid");
@@ -287,8 +302,20 @@ describe("SelectableDataTable", () => {
     expect(sdaChild).not.toBeNull();
   });
 
-  it.todo("allows selectionMode#none");
-  it.todo("renders nothing for actions column if actions is an empty collection");
+  it("allows selectionMode#none", () => {
+    plainRender(<SelectableDataTable {...props} selectionMode="none" />);
+    const table = screen.getByRole("grid");
+    expect(within(table).queryAllByRole("radio")).toEqual([]);
+    expect(within(table).queryAllByRole("checkbox")).toEqual([]);
+  });
+
+  it.skip("renders nothing for actions column if actions is an empty collection", () => {
+    // TODO: requires a refactor  to correctly hide the actions column header
+    // when no items have actions. Check TODO note in the component
+    plainRender(<SelectableDataTable {...props} itemActions={() => []} />);
+    const table = screen.getByRole("grid");
+    expect(within(table).queryByRole("columnheader", { name: "Row actions" })).toBeNull();
+  });
 
   describe("when not providing a custom item equality function", () => {
     const onSelectionChange = jest.fn();