Storage service applies the product's configuration#312
Merged
Conversation
dgdavid
approved these changes
Nov 17, 2022
| # Probes storage devices and performs an initial proposal | ||
| def probe | ||
| start_progress(4) | ||
| config.pick_product(software.selected_product) |
Contributor
There was a problem hiding this comment.
I don't like to have this here. Note that this class does not need the config at all. The config is used by Storage::Proposal and Security, so I would expect that classes retrieve the current config somehow. I think we need to re-think the config approach completely.
Contributor
Author
There was a problem hiding this comment.
Yes, I agree. I would keep the changes to the bare minimum, but it is clear that we need to evolve the configuration handling. I will add this information to #189.
dgdavid
approved these changes
Nov 17, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The storage service takes the selected product into account before performing the probing. It fixes #311.
PS: we should do something similar for the network service, but there is no network configuration in the YAML file, so we can keep it as it is now.