Activate the manager service without systemd#307
Merged
Conversation
Remove the unnecessary difference from the other services. dbus-daemon starts it just fine.
ancorgs
approved these changes
Nov 16, 2022
Contributor
ancorgs
left a comment
ancorgs
left a comment
There was a problem hiding this comment.
LGTM, the simpler the better
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #295
Problem
We are starting one of the handful of services in a different way, via systemd instead of via dbus-daemon.
There is no reason other than I wanted to try if it works. It just adds complexity.
Solution
Remove the unnecessary difference from the other services. dbus-daemon starts it just fine.
Testing
./setup.sh; open browser to see no error; verify withd-installer -sScreenshots
Not affected