Skip to content

web: fix label used for introducing product selection #3065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgdavid merged 1 commit into from
Jan 22, 2026
Merged

web: fix label used for introducing product selection #3065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 25 additions & 8 deletions web/src/components/product/ProductSelectionPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,30 @@ type ProductFormProps = {
isSubmitted: boolean;
};

const ProductFormLabel = ({ products, currentProduct }) => {
// Calculate the number of available products, excluding the current product if selected
const availableProductCount = currentProduct ? products.length - 1 : products.length;

// TODO: Refactor once mode selection is implemented
// When mode selection is added, check if there is only one product left,
// and if so, handle the display to allow switching between modes for that product.
//
// if (availableProductCount === 0) {
// return sprintf(_("Switch to one of %d other modes"), products[0].modes.length);
// }

return sprintf(
n_(
"Switch to another available product",
// TODO: One modes is implemented, the label should reflect switching to
// available products or their modes
"Choose from %d available products",
availableProductCount,
),
availableProductCount,
);
};

/**
* Form for selecting a product.
*
Expand Down Expand Up @@ -326,14 +350,7 @@ const ProductForm = ({ products, currentProduct, isSubmitted, onSubmit }: Produc
<Form id="productSelectionForm" onSubmit={onFormSubmission}>
<FormGroup
role="radiogroup"
label={sprintf(
n_(
"Switch to other available product",
"Choose from %d available products",
products.length - 1,
),
products.length - 1,
)}
label={<ProductFormLabel products={products} currentProduct={currentProduct} />}
>
<List isPlain>
{products.map((product, index) => {
Expand Down