Skip to content

Force to use only one candidate device#306

Closed
imobachgs wants to merge 1 commit intomasterfrom
force-one-candidate-device
Closed

Force to use only one candidate device#306
imobachgs wants to merge 1 commit intomasterfrom
force-one-candidate-device

Conversation

@imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Nov 15, 2022

Problem

After merging #268, there is a mismatch between the UI and the backend. By default, the backend selects many candidate_devices (as shown in the screenshot below).

Captura desde 2022-11-15 06-52-39

However, the UI only allows selecting a single device. Initially, I thought about extending the UI, but as you cannot specify any volume yet, there is no point in doing selecting more than one device. Actually, the result of the current behavior, is that /dev/sdc GPT gets removed for no good reason.

Solution

I would force the use of a single device by now, so we can release the new version as soon as possible. After all, we are expected to work on the storage UI for the next-next release, so we can address this problem in a proper way.

I am proposing a solution but, to be honest, I am not sure if it is the "best" way. Please, let me know if you think we should do something different.

Captura desde 2022-11-15 07-03-27

Testing

  • Set a unit test to pending 😞
  • Tested manually

Screenshots

If the fix affects the UI attach some screenshots here.

@imobachgs imobachgs changed the title [service] Force to use only one candidate device Force to use only one candidate device Nov 15, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 74.789% when pulling 7a71408 on force-one-candidate-device into 621efea on master.

@joseivanlopez
Copy link
Contributor

Closing in favor of #309.

@imobachgs imobachgs deleted the force-one-candidate-device branch November 23, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants