Closed
Conversation
Contributor
|
Closing in favor of #309. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After merging #268, there is a mismatch between the UI and the backend. By default, the backend selects many
candidate_devices(as shown in the screenshot below).However, the UI only allows selecting a single device. Initially, I thought about extending the UI, but as you cannot specify any volume yet, there is no point in doing selecting more than one device. Actually, the result of the current behavior, is that
/dev/sdcGPT gets removed for no good reason.Solution
I would force the use of a single device by now, so we can release the new version as soon as possible. After all, we are expected to work on the storage UI for the next-next release, so we can address this problem in a proper way.
I am proposing a solution but, to be honest, I am not sure if it is the "best" way. Please, let me know if you think we should do something different.
Testing
Screenshots
If the fix affects the UI attach some screenshots here.