Skip to content

[web] Display only one primary action when editing a connection#305

Merged
imobachgs merged 2 commits intomasterfrom
small-ui-improvements
Nov 15, 2022
Merged

[web] Display only one primary action when editing a connection#305
imobachgs merged 2 commits intomasterfrom
small-ui-improvements

Conversation

@dgdavid
Copy link
Contributor

@dgdavid dgdavid commented Nov 14, 2022

Problem

The popup shown when editing a connection ends up displaying three buttons that looks like primary actions, which might be a bit confusing.

Solution

Try to use only one primary action per dialog, as we did in #292.

Screenshots

After Before
Dialog with more than one primary action Dialog with only one primary action

@dgdavid dgdavid changed the title [web] Display only one primary action in the edit connection popup [web] Display only one primary action when editing a connection Nov 14, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.747% when pulling 91dbbf8 on small-ui-improvements into 30bd6dd on master.

Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit ea47452 into master Nov 15, 2022
@imobachgs imobachgs deleted the small-ui-improvements branch November 15, 2022 07:18
@imobachgs imobachgs mentioned this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants