Conversation
## Problem Up to Agama 18, part of the network configuration was done using the [Agama::Network Ruby class](https://github.com/agama-project/agama/blob/master/service/lib/agama/network.rb ""). The method `startup` was called during Agama start-up and `install`during the installation process. We need to implement the same logic in the `api-v2`branch using Rust. Note: We should consider to copy all the connections from `/etc/NetworkManager/system-connections` as we used to do at least until Agama is aware of new connections added by NetworkManager. See[https://bugzilla.suse.com/show_bug.cgi?id=1254492#c25](https://bugzilla.suse.com/show_bug.cgi?id=1254492#c25 "smartCard-inline") - https://trello.com/c/ixm9Fz0J/5460-add-support-to-initialize-and-finish-the-network-configuration ## Solution Implemented the network startup and install methods in the backend network service. ## Tests - Tested manually ## TODO ### When starting the service - [x] Propose default configuration when starting the service. ### When calling install - [X] Copy connections to the target system. - [X] Enable NetworkManager service - [ ] Configure the proxy in the target system. ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It merges api-v2 mainly because of #3006