Conversation
imobachgs
approved these changes
Nov 11, 2022
Remove duplicated allow[@send_destination]. Sending to the Introspectable interface is the only thing allowed to non-root clients -> moved to policy[@context="default"] Receiving is allowed by default, no need to mention allow[@receive_sender]. See the (terse) docs at https://manpages.org/dbus-daemon
It might seem courteous to allow non-root at least introspect our API via d-feet, since the documentation is public anyway and this would be a guaranteed up-to-date version, right? But our services do a lot of probing at startup, so we might have a bug where we would modify something as root when triggered by a curious introspector. Better not allow it. Let them `sudo -E d-feet`.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In https://bugzilla.suse.com/show_bug.cgi?id=1202059 we are asking for a security review of our D-Bus service.
But the relevant bus policy file is hard to read.
Solution
Simplify the policy file while keeping it equivalent.
Testing
Owning the bus name:
Non-root should fail
bundle exec bin/d-installer questionsRoot should succeed
sudo !!Introspection call:
Non-root should fail
busctl introspect org.opensuse.DInstaller.Questions /org/opensuse/DInstaller/Questions1Root should succeed:
sudo !!Question API call:
Non-root should fail
Root should succeed:
sudo !!Screenshots
Not affected