Conversation
Contributor
imobachgs
commented
Dec 24, 2021
imobachgs
commented
- Replace the Rails-based implementation with an EventMachine + Sinatra one.
- Notify properties changes over D-Bus.
- Refresh the UI when something changes.
- Reorder the ports: 3000 for UI, 3001 for HTTP/JSON, 3002 for WS.
* 3000 for the UI, 3001 for the proxy and 3002 for the websocket.
* DBusClient uses ruby-dbus and does not rely on busctl anymore.
dgdavid
added a commit
that referenced
this pull request
Sep 13, 2024
**Apart from a bit of clean up, this PR is intended for start writing better core components** that has been on hold for a few months already. It's the case of _core/Page_ component, which has been rewritten almost for scratch and now makes the weird _core/CardField transitioning component_ obsolete. Please, note that this set of changes **continues with the migration to TypeScript for touched files** and also **introduce a PatternFly/Flex wrapper** in order to ease the work with its responsive props. It's a bit complex because the (ab)use of advanced types but it does the job without introducing props unknown by PF/Flex. As said in the file comments, ideally > would be better to add these responsive props shortcuts direclty in PF/Flex to allow the consumer to just set the `default` value when not needed to change it depending on the breakpoint. But at this moment we're a bit short of time for creating and testing such an elaborated PR against upstream. --- Related to #1441 and #1494
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.