Use cockpit.proxies and reduce the number of async methods#293
Merged
imobachgs merged 6 commits intofeature/wireless-supportfrom Nov 4, 2022
Merged
Use cockpit.proxies and reduce the number of async methods#293imobachgs merged 6 commits intofeature/wireless-supportfrom
cockpit.proxies and reduce the number of async methods#293imobachgs merged 6 commits intofeature/wireless-supportfrom
Conversation
dgdavid
approved these changes
Nov 3, 2022
7b923da to
54fd477
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the network client to:
cockpit.proxies, making it easier to track the changes (using events onproxies) and to read the properties;asyncmethods in the network client.We can use the same approach for objects like
/org/freedesktop/NetworkManager, but let's do it as a separate PR.