Skip to content

Use cockpit.proxies and reduce the number of async methods#293

Merged
imobachgs merged 6 commits intofeature/wireless-supportfrom
refactor/proxies
Nov 4, 2022
Merged

Use cockpit.proxies and reduce the number of async methods#293
imobachgs merged 6 commits intofeature/wireless-supportfrom
refactor/proxies

Conversation

@imobachgs
Copy link
Contributor

This PR refactors the network client to:

  • use cockpit.proxies, making it easier to track the changes (using events on proxies) and to read the properties;
  • reduce the number of async methods in the network client.

We can use the same approach for objects like /org/freedesktop/NetworkManager, but let's do it as a separate PR.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 71.08% when pulling 6418032 on refactor/proxies into 70dbb4f on feature/wireless-support.

@coveralls
Copy link

coveralls commented Nov 3, 2022

Coverage Status

Coverage increased (+0.4%) to 71.08% when pulling 54fd477 on refactor/proxies into 70dbb4f on feature/wireless-support.

@imobachgs imobachgs merged commit f443dc3 into feature/wireless-support Nov 4, 2022
@imobachgs imobachgs deleted the refactor/proxies branch November 4, 2022 06:30
@imobachgs imobachgs mentioned this pull request Nov 16, 2022
@imobachgs imobachgs restored the refactor/proxies branch November 23, 2022 09:04
@imobachgs imobachgs deleted the refactor/proxies branch November 23, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants