Adapt network to the new config based HTTP API (backend)#2862
Merged
Adapt network to the new config based HTTP API (backend)#2862
Conversation
Co-authored-by: Imobach González Sosa <igonzalezsosa@suse.com>
3ced1f6 to
1b02ac9
Compare
78df5ad to
f5f25e7
Compare
imobachgs
approved these changes
Nov 11, 2025
| pub async fn for_network_manager() -> NetworkSystem<NetworkManagerAdapter<'static>> { | ||
| let adapter = NetworkManagerAdapter::from_system() | ||
| .await | ||
| .expect("Could not connect to NetworkManager"); |
Contributor
There was a problem hiding this comment.
I wonder if it would be better to return a Result instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There is a new config based HTTP API and all the services needs to be adapted. The aim of this PR is to adapt the network backend service (replace #2840).
Solution
In the new architecture all the Agama modules will live in its own package implementing the actors/service as described in (#2715), but as network was already using a actors model using an enums approach it was decided to use the current service in the first iteration of changes.
Changes done
TODO