Fix an error allocating partitions within RAIDs#2854
Merged
Conversation
ancorgs
force-pushed
the
bug_partitioned_raid
branch
3 times, most recently
from
53261be to
955eee4
Compare
ancorgs
changed the title
ancorgs
force-pushed
the
bug_partitioned_raid
branch
from
cb75b43 to
4279d2c
Compare
ancorgs
added a commit
that referenced
this pull request
Nov 12, 2025
This is a merge of #2854 into the master branch. **Bonus:** This also includes a change in one of the existing tests to make it more robust. See the comment below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
During some manual testing, @tacerus found a pretty serious bug in the Agama storage proposal.
When distributing several partitions over several new MD RAIDs, it may happen that Agama locates some of those partitions in the WRONG RAID DEVICE!
That happened because Agama tried to optimize the size distribution of those partitions, but in the process it ignored a very basic constraint: the exact RAID in which those partitions should be created.
Solution
Honor the relationship between new MDs and its partitions.
Testing
Unit tests included