Fix consecutive bulk actions in the list of DASD#2812
Merged
ancorgs merged 2 commits intoagama-project:SLE-16from Oct 14, 2025
Merged
Fix consecutive bulk actions in the list of DASD#2812ancorgs merged 2 commits intoagama-project:SLE-16from
ancorgs merged 2 commits intoagama-project:SLE-16from
Conversation
129e14c to
ca2145f
Compare
imobachgs
approved these changes
Oct 14, 2025
Contributor
imobachgs
left a comment
There was a problem hiding this comment.
It is OK as a workaround. I wonder if we could do it better by having just ids in selectedDevices and devicesToFormat. However, I would stick to this solution by now.
Contributor
Author
Yes. I would happily rethink the whole component. Avoiding to do so here because this is a fix for the stable SLE-16 branch (targeting QU0, so minimal changes only). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The following steps resulted in a wrong error pop-up.
The UI wrongly displayed a warning like "Cannot format all selected devices. The devices below are offline and cannot be formatted."
https://bugzilla.suse.com/show_bug.cgi?id=1243795
Solution
After activating the DASD disks, update the list of objects that represent those disks and that is used to decide whether the mentioned warning should be displayed.
Testing
Tested manually in a s390 system.