Skip to content

Fix consecutive bulk actions in the list of DASD#2812

Merged
ancorgs merged 2 commits intoagama-project:SLE-16from
ancorgs:bsc1243795-sle16
Oct 14, 2025
Merged

Fix consecutive bulk actions in the list of DASD#2812
ancorgs merged 2 commits intoagama-project:SLE-16from
ancorgs:bsc1243795-sle16

Conversation

@ancorgs
Copy link
Copy Markdown
Contributor

@ancorgs ancorgs commented Oct 14, 2025

Problem

The following steps resulted in a wrong error pop-up.

  1. Select a disk (or more) that is offline and not formatted.
  2. Click on the button "activate" at the top of the list.
  3. Wait for the disk to be activated.
  4. Click on the button "format" at the top of the list.

The UI wrongly displayed a warning like "Cannot format all selected devices. The devices below are offline and cannot be formatted."

https://bugzilla.suse.com/show_bug.cgi?id=1243795

Solution

After activating the DASD disks, update the list of objects that represent those disks and that is used to decide whether the mentioned warning should be displayed.

Testing

Tested manually in a s390 system.

@ancorgs ancorgs marked this pull request as ready for review October 14, 2025 14:04
Copy link
Copy Markdown
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is OK as a workaround. I wonder if we could do it better by having just ids in selectedDevices and devicesToFormat. However, I would stick to this solution by now.

@ancorgs ancorgs merged commit cc57d61 into agama-project:SLE-16 Oct 14, 2025
2 checks passed
@ancorgs
Copy link
Copy Markdown
Contributor Author

ancorgs commented Oct 14, 2025

It is OK as a workaround. I wonder if we could do it better by having just ids in selectedDevices and devicesToFormat. However, I would stick to this solution by now.

Yes. I would happily rethink the whole component. Avoiding to do so here because this is a fix for the stable SLE-16 branch (targeting QU0, so minimal changes only).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants