agama-network: add ipv4.link-local for ZeroConf/AutoIP#2792
Merged
teclator merged 2 commits intoagama-project:masterfrom Oct 10, 2025
Merged
agama-network: add ipv4.link-local for ZeroConf/AutoIP#2792teclator merged 2 commits intoagama-project:masterfrom
teclator merged 2 commits intoagama-project:masterfrom
Conversation
jcronenberg
reviewed
Oct 7, 2025
teclator
reviewed
Oct 7, 2025
cfconrad
force-pushed
the
add_ipconfig_link_local4
branch
2 times, most recently
from
f97bd7f to
e80c62a
Compare
jcronenberg
reviewed
Oct 7, 2025
cfconrad
force-pushed
the
add_ipconfig_link_local4
branch
from
e80c62a to
4e5ba1c
Compare
cfconrad
commented
Oct 9, 2025
rust/agama-network/src/nm/dbus.rs
Outdated
| let link_local = if ip_config.link_local4 == LinkLocal::Fallback | ||
| && VersionReq::parse("<1.52.0").unwrap().matches(nm_version) | ||
| { | ||
| LinkLocal::Auto |
Contributor
Author
There was a problem hiding this comment.
Just realized, that link-local=auto with ipv4.method=auto will not use zeroconf in addition to DHCP on the interface. As link-local=auto actually mean, use the value from ipv4.method.
Change this to link-local=enabled, then we have a AutoIP and the DHCPv4 address. So the difference between the NetworkManager versions is
<1.52: The interface will always have a zeroconf IP address, ALSO after DHCP
>=1.52: The zeroconf IP-Address will be removed, once the DHCP lease is applied
Sorry for the late noise!
Add the field IpConfig.link_local4, which represent NetworkManager `ipv4.link-local` field. This is needed duo the migration of the following ifconfig ``` BOOTPROTO=dhcp+autoip ``` which lead to ``` ipv4.method=auto ipv4.link-local=fallback (4) ```
cfconrad
force-pushed
the
add_ipconfig_link_local4
branch
from
4e5ba1c to
4adb47a
Compare
cfconrad
force-pushed
the
add_ipconfig_link_local4
branch
from
4adb47a to
2ab4add
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the field IpConfig.link_local4, which represent NetworkManager
ipv4.link-localfield.This is needed duo the migration of the following ifconfig
which lead to
Testing