Explicitly tell user to start the service#277
Merged
imobachgs merged 1 commit intoagama-project:masterfrom Oct 28, 2022
lkocman:master
Merged
Explicitly tell user to start the service#277imobachgs merged 1 commit intoagama-project:masterfrom lkocman:master
imobachgs merged 1 commit intoagama-project:masterfrom
lkocman:master
Conversation
imobachgs
approved these changes
Oct 28, 2022
Contributor
imobachgs
left a comment
There was a problem hiding this comment.
It makes sense. Thanks!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This explicit mention of starting the service will save one step to the first-timer:
The readme says ./setup.sh will do all the work, and then simply point to http://localhost:9090/cockpit/@localhost/d-installer/index.html#/products. But then you login to cockpit and get "unable to connect to dbus".
Setup.sh tells user to run the service
But since it printed also "visit ... sentence" right after, I expected that perhaps that was also covered by setup.sh and it's simply just printed by some subcommand.
Solution
Add explicit task to start the service to README.md
Testing
n/a just a nitpicking on docs.
Screenshots