fix(web): Preserve installer options values after successful submission#2746
Merged
fix(web): Preserve installer options values after successful submission#2746
Conversation
Ensure form controls are reset to their initial values only on cancellation. Since the form remains mounted, it should preserve the submitted state when closed after a successful submission.
To make match other form actions naming.
Contributor
|
LGTM from the program logic point of view, but I know much too little about TypeScript to do a proper review here. |
Contributor
Author
Not that much knowledge about TS needed here, though 😝 |
Contributor
Author
I just skipped to add a unit test for this behavior because it is not that easy with our current architecture for unit testing in which callbacks are mocked and the state of the form is not persisted as it is when using it in the app. But if someone has an idea about how to do it, I'm all ears 👂 |
dgdavid
added a commit
that referenced
this pull request
Sep 22, 2025
…on (#2746) Ensure installer options form controls are reset to their initial values only on cancellation. Since the form remains mounted, it should preserve the submitted state when closed after a successful submission. Fixes https://bugzilla.suse.com/show_bug.cgi?id=1249636 (protected link)
imobachgs
added a commit
that referenced
this pull request
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure installer options form controls are reset to their initial values only on cancellation. Since the form remains mounted, it should preserve the submitted state when closed after a successful submission.
Fixes https://bugzilla.suse.com/show_bug.cgi?id=1249636 (protected link)