Reset to the text console before exiting grub2 (bsc#1248167)#2726
Closed
lcp wants to merge 2 commits intoagama-project:masterfrom
Closed
Reset to the text console before exiting grub2 (bsc#1248167)#2726lcp wants to merge 2 commits intoagama-project:masterfrom
lcp wants to merge 2 commits intoagama-project:masterfrom
Conversation
The 'Boot from Hard Disk' menu entry exits grub2 and gives back the control to the system firmware, e.g. BIOS or UEFI. Without resetting the terminal output to the text console, SeaBIOS may not clean up the screen and output messages correctly. Signed-off-by: Gary Lin <glin@suse.com>
lcp
force-pushed
the
fix-seabios-screen
branch
from
c53d312 to
a036307
Compare
Author
|
Ping? |
Contributor
|
I think "boot from hard disk" was dropped here for EFI systems. #3185 If that's the case, that would obsolete this PR and the corresponding boot report. @jreidinger (as author of the mentioned PR) Can you check? |
Contributor
|
@ancorgs this code is only for non-efi, so still relevant...just condition is not needed. |
Author
Yes, the fix is for the legacy BIOS. I'll remove the condition since "Boot from hard disk" is dropped for EFI. |
Author
|
Hmm the logic of "Boot from Hard Disk" changed. It now uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'Boot from Hard Disk' menu entry exits grub2 and gives back the control to the system firmware, e.g. BIOS or UEFI. Without resetting the terminal output to the text console, SeaBIOS may not clean up the screen and output messages correctly.
Ref: https://bugzilla.suse.com/show_bug.cgi?id=1248167