Closed
Conversation
* The old DInstaller::Network class is now DInstaller::Network::Manager.
* It only implements the API required by D-Installer.
imobachgs
force-pushed
the
network-api
branch
from
916a275 to
2c7da07
Compare
imobachgs
force-pushed
the
network-api
branch
4 times, most recently
from
b7abaa9 to
23d8637
Compare
imobachgs
force-pushed
the
network-api
branch
from
23d8637 to
243384e
Compare
Contributor
Author
|
We experimented with the idea of building a minimal Ruby-based D-Bus interface on top of the NetworkManager API. The plan was to avoid re-implementing the same logic in our web UI and the CLI. However, far from making things easier, it added quite some complexity. Consequently, we decided to drop this approach in favor of just #260. And if you need a CLI during the installation, just use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Short description of the original problem.
Solution
Short description of the fix.
Testing
Screenshots
If the fix affects the UI attach some screenshots here.