Configure nameservers#271
Merged
teclator merged 2 commits intofeature/network-overviewfrom Oct 20, 2022
Merged
Conversation
teclator
force-pushed
the
write_nameservers_config
branch
from
d8533c1 to
181a3ed
Compare
teclator
force-pushed
the
write_nameservers_config
branch
from
181a3ed to
e081d2b
Compare
imobachgs
approved these changes
Oct 20, 2022
Pull Request Test Coverage Report for Build 3289997799
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3289997799
💛 - Coveralls |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently the ipv4 dns configuration is not touched, we should allow to set some DNS server specially when the IP configuration is statically configured.
Solution
Modify ipv4 dns configuration when the settings are touched.
Testing
Screenshots