Conversation
Contributor
|
It looks good. It just a matter of adapting the unit tests. Thanks! Related to #260. |
Pull Request Test Coverage Report for Build 3279635664
💛 - Coveralls |
Pull Request Test Coverage Report for Build 3279740014
💛 - Coveralls |
imobachgs
approved these changes
Oct 19, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When we started with the installer we added support for basic network setup using the defaults from the control file which in case of ALP is not present anymore.
Solution
As currently we will not support other backends apart of NetworkManager we will enforce the selected backend as NetworkManager and will continue relying in the y2network save_network client in order to copy the config and enable the service at the end of the installation