Add the internal device id to the updated device (bsc#1247445).#2680
Merged
Add the internal device id to the updated device (bsc#1247445).#2680
Conversation
teclator
changed the title
jreidinger
approved these changes
Aug 27, 2025
teclator
added a commit
that referenced
this pull request
Mar 24, 2026
When a zFCPController is activated the UI is not refreshed properly maintaining it as inactive. - https://trello.com/c/5SeUZvuG - https://bugzilla.suse.com/show_bug.cgi?id=1247445 The problem is that the changed device does not contain its id, therefore we are not replacing it at all. For refreshing the **zFCP** Controllers table, just notifying the device id and replacing the object should be enough, but we need to retrieve also the disks associated with the activated controller and this is done through the controllers query, therefore, we invalidate it after any controllers change. The only thing that could be improved is that it takes some time to get the list of LUNs and the controllers selector updated. - *Tested manually*
teclator
added a commit
that referenced
this pull request
Mar 24, 2026
When a zFCPController is activated the UI is not refreshed properly maintaining it as inactive. - https://trello.com/c/5SeUZvuG - https://bugzilla.suse.com/show_bug.cgi?id=1247445 The problem is that the changed device does not contain its id, therefore we are not replacing it at all. For refreshing the **zFCP** Controllers table, just notifying the device id and replacing the object should be enough, but we need to retrieve also the disks associated with the activated controller and this is done through the controllers query, therefore, we invalidate it after any controllers change. The only thing that could be improved is that it takes some time to get the list of LUNs and the controllers selector updated. - *Tested manually*
teclator
added a commit
that referenced
this pull request
Mar 25, 2026
… (#3326) Original fix and description from #2680 backported to SLE-16 branch When a zFCPController is activated the UI is not refreshed properly maintaining it as inactive - https://trello.com/c/5SeUZvuG - https://bugzilla.suse.com/show_bug.cgi?id=1247445 The problem is that the changed device does not contain its id, therefore we are not replacing it at all. For refreshing the **zFCP** Controllers table, just notifying the device id and replacing the object should be enough, but we need to retrieve also the disks associated with the activated controller and this is done through the controllers query, therefore, we invalidate it after any controllers change. The only thing that could be improved is that it takes some time to get the list of LUNs and the controllers selector updated. - *Tested manually* **Update**: In recent changes it has been also reported that when a controller is activated apart of the controller **LUNs** the disks table is populated with the other controller **LUNs**. The problem is that retrieving the controllers also tries to get the luns of each controller through the **zfcp_san_disc** which activates temporally the controller in question. We should get only the LUNs for the active controllers and that is what has been also implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a zFCPController is activated the UI is not refreshed properly maintaining it as inactive.
Solution
The problem is that the changed device does not contain its id, therefore we are not replacing it at all. For refreshing the zFCP Controllers table, just notifying the device id and replacing the object should be enough, but we need to retrieve also the disks associated with the activated controller and this is done through the controllers query, therefore, we invalidate it after any controllers change.
The only thing that could be improved is that it takes some time to get the list of LUNs and the controllers selector updated.
Testing