Implemented --local option to allow profile validation without accessing agama server#2670
Merged
Implemented --local option to allow profile validation without accessing agama server#2670
Conversation
jreidinger
reviewed
Aug 25, 2025
Contributor
|
looks good, please add changelog |
--local is the Config specific option, other commands seems to depend on remote connection
mchf
force-pushed
the
cli-offline-validation
branch
from
27c0499 to
565773d
Compare
jreidinger
approved these changes
Aug 26, 2025
mchf
force-pushed
the
cli-offline-validation
branch
from
8afa566 to
7906774
Compare
Contributor
Author
|
Moving --local option into agama config validate was discussed with @imobachgs off the github |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
bsc#1247424
Originally agama-cli performed profile validation by asking agama server through HTTP API. This might complicate migration from older products sometimes.
Solution
Implemented --local option so you can ask
agama config --local validatefor checking the profile and CLI won't send it to agama server.The option
--localwas implemented asconfigcommand specific as I didn't identify any other command where it could make sense.TODO:
refactoringtest other config subcommands and identify those which might work with --local as wellSo far didn't find any other which makes sense or could work locally. So if no idea appears during the review may be it is a time to move the option even one more level lower (agama config validate --local)Testing