feat(web): improve layout and accuracy of wired connection details#2639
Merged
feat(web): improve layout and accuracy of wired connection details#2639
Conversation
Introduced a binding settings section in the connection details page as a first step toward displaying more accurate information. Moved some pieces of code to avoid code duplication.
In the connection details view, add support for rendering information for all devices associated with a connection. Multi-device support is currently rudimentary and will be refined in future work.
The connection details page now displays the actual connection settings, rather than those from the first device using the connection. To make this clearer, the "IP Settings" section has been renamed to "Connection Settings", building on the previous change that added the "Devices connected" section. This change also helps reduce the mismatch between the data shown in the details view and the settings introduced in the corresponding form.
Improved the usability of the "Connected devices" section in the connection details page by introducing tabs when more than one device shares the connection. This change helps users more easily navigate and access the information for each device and its details.
dgdavid
changed the title
ancorgs
reviewed
Aug 6, 2025
ancorgs
reviewed
Aug 6, 2025
ancorgs
reviewed
Aug 6, 2025
ancorgs
reviewed
Aug 6, 2025
Contributor
ancorgs
left a comment
ancorgs
left a comment
There was a problem hiding this comment.
This generally looks great! I just have some reservations about the definition and usage of some strings.
Based on suggestions from code review.
As agreed, although these terms are somewhat interchangeable in the network area, consistently using a single term improves usability. 'Device' was chosen over 'interface' because it’s more tangible and closer to the physical world, making the UI easier to understand. The term 'interface' is still used when listing device properties, to help build a mental model for users and ease the connection between both concepts. Additionally, the label "Any interface" has been changed to "Unbound" instead of "Any device", as it sounds simpler and more accurate.
Suggested in the code review, check #2639 (comment)
Contributor
|
Also LGTM, it really fixes some of the issues we had. |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Aug 13, 2025
https://build.opensuse.org/request/show/1299043 by user IGonzalezSosa + dimstar_suse - Split progress details into two lines for better readability (gh#agama-project/agama#2647). - Improve layout and accuracy of wired connection details view (bsc#1247430, gh#agama-project/agama#2639). - Block UI if storage is configured by any other client (gh#agama-project/agama#2640).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces several enhancements to the wired connection details view, aiming to improve both the accuracy of the shown data and the usability of the layout, especially in cases where multiple devices share a connection.
To achieve this, the following actions were taken:
Fixed connection settings display
The details page now shows the actual connection settings, rather than using those from the first connected device. This drop the mismatch between the details view and the corresponding connection form.
Added "Binding Settings" section
To clearly displays whether the connection is bound to a specific device and how (by MAC address or device name), rather than just showing information for the first device using it.
Added support for multiple devices
When multiple devices share a connection, users can switch between them using a tabbed section, making it easier to view and compare individual device details.
Reorganized layout for clarity
The layout has been adjusted to better group related information and improve overall readability.
Click to show/hide some screenshots
Before changes
NOTE: below screenshots might be slightly outdated due to suggestions from code review. They will be updated only if the final result changes noticeable
After changes, with only one device using the connection
After changes, with more than one device sharing the connection
👉 Follow up work: do the same for
WifiConnectionDetails, once this is reviewwed, adjusted, approved, and merged.Related to https://trello.com/c/MqZ19UnL (protected link)