Skip to content

Document a proposal for the storage UI#255

Merged
ancorgs merged 2 commits intomasterfrom
doc_storage_proposal
Oct 10, 2022
Merged

Document a proposal for the storage UI#255
ancorgs merged 2 commits intomasterfrom
doc_storage_proposal

Conversation

@ancorgs
Copy link
Contributor

@ancorgs ancorgs commented Oct 7, 2022

We need a way to define in the D-Installer UI which partitions and LVM logical volumes should be created and how to make space for them if we are not installing in an empty disk.

We need something that is:

  • As automatic as the YaST Guided Setup
  • Easier to understand than YaST Guided Setup
  • Almost as flexible as the YaST Expert Partitioner

This pull request documents a proposal for such an UI. For better review, use the Github option "View File" on doc/storage_ui.md.

@ancorgs ancorgs marked this pull request as draft October 7, 2022 11:24
@coveralls
Copy link

coveralls commented Oct 7, 2022

Pull Request Test Coverage Report for Build 3206303767

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.6%) to 73.023%

Totals Coverage Status
Change from base Build 3128967461: -3.6%
Covered Lines: 1708
Relevant Lines: 2339

💛 - Coveralls

@ancorgs ancorgs force-pushed the doc_storage_proposal branch 3 times, most recently from 939be29 to b7e849b Compare October 7, 2022 12:38
@ancorgs ancorgs force-pushed the doc_storage_proposal branch from b7e849b to 4299187 Compare October 7, 2022 12:40
Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ancorgs ancorgs force-pushed the doc_storage_proposal branch 2 times, most recently from 6fca5f7 to 64781d3 Compare October 7, 2022 16:18
@ancorgs ancorgs marked this pull request as ready for review October 7, 2022 16:19
@ancorgs ancorgs changed the title WIP: document a proposal for the storage UI Document a proposal for the storage UI Oct 7, 2022
@ancorgs ancorgs force-pushed the doc_storage_proposal branch from 64781d3 to 0db234f Compare October 7, 2022 16:38
@ancorgs ancorgs force-pushed the doc_storage_proposal branch from 0db234f to 1f297a8 Compare October 7, 2022 16:40
Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't Take Mock-ups Too Seriously

First of all, bear in mind the screenshots are far from being a faithfull representation of the
final look & feel. This document presents the concept focusing on the elements that should be there and how they will interact.

So, LGTM 😜

@ancorgs ancorgs merged commit 5bca59a into master Oct 10, 2022
@ancorgs ancorgs deleted the doc_storage_proposal branch October 10, 2022 08:17
@imobachgs imobachgs mentioned this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants