Skip to content

Add missing attempt param to LUKS activation questions#251

Merged
dgdavid merged 2 commits intomasterfrom
fix-luks-attemtps
Sep 14, 2022
Merged

Add missing attempt param to LUKS activation questions#251
dgdavid merged 2 commits intomasterfrom
fix-luks-attemtps

Conversation

@dgdavid
Copy link
Copy Markdown
Contributor

@dgdavid dgdavid commented Sep 14, 2022

Problem

LuksActivationQuestion is not displaying any hint about a wrong password entered. See #165 (comment)

Solution

Add the missing attempt param when registering the question in D-Bus.

Testing

  • Adapted unit tests.

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 14, 2022

Pull Request Test Coverage Report for Build 3053350932

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.3%) to 78.924%

Totals Coverage Status
Change from base Build 3035415875: 2.3%
Covered Lines: 602
Relevant Lines: 738

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I implemented the same change in my local copy (I needed it to check other stuff) and I can confirm this works.

@dgdavid dgdavid merged commit 66c1bec into master Sep 14, 2022
@dgdavid dgdavid deleted the fix-luks-attemtps branch September 14, 2022 14:19
@imobachgs imobachgs mentioned this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants