Skip to content

fix(web): keep left margin for main container in xl breakpoint #2370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgdavid merged 2 commits into from
May 19, 2025
Merged

fix(web): keep left margin for main container in xl breakpoint #2370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7afddd2
fix(web): keep left margin for main container in xl breakpoint
dgdavid May 19, 2025
3906ddf
doc(web): add entry in changes file
dgdavid May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions web/package/agama-web-ui.changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
-------------------------------------------------------------------
Mon May 19 13:38:16 UTC 2025 - David Diaz <dgonzalez@suse.com>

- Keep margin between sidebar and main content in all breakpoints
(gh/agama-project/agama#2370).

-------------------------------------------------------------------
Fri May 16 07:46:22 UTC 2025 - David Diaz <dgonzalez@suse.com>

Expand Down
4 changes: 4 additions & 0 deletions web/src/assets/styles/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,10 @@

// Reserve the sidebar space also for "lg" breakpoint
@media (width >= 64rem) {
.pf-v6-c-page__main-container {
--pf-v6-c-page__main-container--MarginInlineStart: var(--pf-v6-c-page--inset);
}

.pf-v6-c-page.agm-full-layout {
--pf-v6-c-page__sidebar--Width: 12rem; // var(--pf-v6-c-page__sidebar--xl--Width);
grid-template-areas:
Expand Down