Skip to content

fix(web): properly handle empty lists of unsupported AutoYaST elements #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imobachgs merged 3 commits into from
Mar 24, 2025
Merged

fix(web): properly handle empty lists of unsupported AutoYaST elements #2197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0678068
fix(web): handle empty list of unsupported elements
imobachgs Mar 24, 2025
14991e5
docs(web): update changes file
imobachgs Mar 24, 2025
6ff281e
Merge branch 'master' into fix-unsupported-ay
imobachgs Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions web/package/agama-web-ui.changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
-------------------------------------------------------------------
Mon Mar 24 10:17:30 UTC 2025 - Imobach Gonzalez Sosa <igonzalezsosa@suse.com>

- Properly handle empty lists of unsupported AutoYaST elements
(gh#agama-project/agama#2196).

-------------------------------------------------------------------
Sun Mar 23 02:13:56 UTC 2025 - David Diaz <dgonzalez@suse.com>

Expand Down
4 changes: 2 additions & 2 deletions web/src/components/questions/UnsupportedAutoYaST.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ describe("UnsupportedAutoYaST", () => {

describe("when there are no unsupported (but planned) elements", () => {
beforeEach(() => {
mockQuestion = { ...question, data: {} };
mockQuestion = { ...question, data: { planned: "" } };
});

it('does not render the "Not implemented yet" list', () => {
Expand All @@ -75,7 +75,7 @@ describe("UnsupportedAutoYaST", () => {

describe("when there are no unsupported (but planned) elements", () => {
beforeEach(() => {
mockQuestion = { ...question, data: {} };
mockQuestion = { ...question, data: { unsupported: "" } };
});

it('does not render the "Not supported" list', () => {
Expand Down
4 changes: 2 additions & 2 deletions web/src/components/questions/UnsupportedAutoYaST.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ export default function UnsupportedAutoYaST({
answerCallback(question);
};

const planned = question.data.planned?.split(",") || [];
const unsupported = question.data.unsupported?.split(",") || [];
const planned = question.data.planned ? question.data.planned.split(",") : [];
const unsupported = question.data.unsupported ? question.data.unsupported.split(",") : [];

return (
<Popup isOpen title={_("Unsupported AutoYaST elements")}>
Expand Down