Merged
Conversation
Using "span" (phrasing content) instead "div" (flow content) for its content. See https://html.spec.whatwg.org/#the-h1,-h2,-h3,-h4,-h5,-and-h6-elements
Removing a not needed extra div.
Named "AdditionalInfo" by now.
Now the footer actions areas is shown always, no matter if it has content or it is empty
All types of questions should add the "Question" aria-label
Pull Request Test Coverage Report for Build 2648791600
💛 - Coveralls |
Pull Request Test Coverage Report for Build 2648827769
💛 - Coveralls |
joseivanlopez
approved these changes
Jul 11, 2022
Contributor
joseivanlopez
left a comment
joseivanlopez
left a comment
There was a problem hiding this comment.
I like this approach! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use react-teleporter for a better layout mechanism.
It allows wrapping the application in the layout only once and influence it from the components by using the created slots. This is far better and optimal than wrapping each main component in the layout and using props for adapting the dynamic parts.
To know more, please read https://gregberge.com/blog/react-scalable-layout and bear in mind that react-teleporter uses React Portals under the hood.
This PR continues/complement/closes #80