[DO NOT MERGE]: just an example from frustration#2079
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
DO NOT MERGE
First of all, please excuse me for:
This PR is not intended to be merged. It’s not fully documented, doesn’t have tests, and the naming could definitely be better. It’s just a PR born out of a developer's frustration while playing the front-end role, realizing that even in 2025, front-end work is still underestimated and treated as second-class citizen.
This is just a wrapper meant to make things easier, avoid repetition, and add some consistency to the code. A wrapper that, in all honesty, wouldn’t be overlooked in a more respected stack (think backend or languages considered more serious), without involving debates over developers’ personal preferences. It also shows that it’s possible to do things a little better from the very beginning without restricting the developers to use the spacing of their preference.
Additionally, it highlights (at least to me) how easy it can be to think about the entire application, rather than just focusing on the part that's working at a given moment—especially when considering future maintenance and reusability.
I know it's a bit rough (read scaring) in its current state, but I hope it helps explain one of the things I’ve been advocating for. It’s not that difficult to write code in a more structured, thoughtful way, rather than relying on repeated lines with the idea that they’ll be fixed later.
I hope a diff speaks louder than my words, as I feel I’ve fully failed to get my point with words.
Related to #2070 (comment), among a ton of other discussions about interface code.