web: Only severe issues prevent installation

web/package/agama-web-ui.changes

@@ -1,3 +1,9 @@
+-------------------------------------------------------------------
+Mon Feb 24 14:17:34 UTC 2025 - Ancor Gonzalez Sosa <ancor@suse.com>
+
+- Ignore non-critical issues to avoid preventing the installation
+  in valid scenarios (gh#agama-project/agama#2061).
+
 -------------------------------------------------------------------
 Mon Feb 24 12:44:15 UTC 2025 - David Diaz <dgonzalez@suse.com>
 

web/src/components/core/InstallButton.test.tsx

@@ -58,7 +58,7 @@ describe("InstallButton", () => {
             description: "Fake Issue",
             kind: "generic",
             source: 0,
-            severity: 0,
+            severity: 1,
             details: "Fake Issue details",
           },
         ],
@@ -131,6 +131,37 @@ describe("InstallButton", () => {
       });
     });
   });
+
+  describe("when there are only non-critical issues", () => {
+    beforeEach(() => {
+      mockIssuesList = new IssuesList(
+        [
+          {
+            description: "Fake warning",
+            kind: "generic",
+            source: 0,
+            severity: 0,
+            details: "Fake Issue details",
+          },
+        ],
+        [],
+        [],
+        [],
+      );
+    });
+
+    it("renders the button without any additional information", async () => {
+      const { user, container } = installerRender(<InstallButton />);
+      const button = screen.getByRole("button", { name: "Install" });
+      // Renders nothing else
+      const icon = container.querySelector("svg");
+      expect(icon).toBeNull();
+      await user.hover(button);
+      expect(
+        screen.queryByRole("tooltip", { name: /Not possible with the current setup/ }),
+      ).toBeNull();
+    });
+  });
 });
 
 describe("InstallConfirmationPopup", () => {

web/src/components/core/InstallButton.tsx

@@ -25,6 +25,7 @@ import { Button, ButtonProps, Stack, Tooltip, TooltipProps } from "@patternfly/r
 import { Popup } from "~/components/core";
 import { startInstallation } from "~/api/manager";
 import { useAllIssues } from "~/queries/issues";
+import { IssueSeverity } from "~/types/issues";
 import { useLocation } from "react-router-dom";
 import { SIDE_PATHS } from "~/routes/paths";
 import { _ } from "~/i18n";
@@ -77,7 +78,7 @@ const InstallButton = (
 ) => {
   const labelId = useId();
   const tooltipId = useId();
-  const issues = useAllIssues();
+  const issues = useAllIssues().filter((i) => i.severity === IssueSeverity.Error);
   const [isOpen, setIsOpen] = useState(false);
   const location = useLocation();
   const hasIssues = !issues.isEmpty;

web/src/components/core/IssuesDrawer.test.tsx

@@ -57,6 +57,27 @@ describe("IssuesDrawer", () => {
     itRendersNothing();
   });
 
+  describe("when there are non-critical issues", () => {
+    beforeEach(() => {
+      mockIssuesList = new IssuesList(
+        [
+          {
+            description: "Registration Fake Warning",
+            kind: "generic",
+            source: 0,
+            severity: 0,
+            details: "Registration Fake Issue details",
+          },
+        ],
+        [],
+        [],
+        [],
+      );
+    });
+
+    itRendersNothing();
+  });
+
   describe("when there are installation issues", () => {
     beforeEach(() => {
       mockIssuesList = new IssuesList(
@@ -65,7 +86,7 @@ describe("IssuesDrawer", () => {
             description: "Registration Fake Issue",
             kind: "generic",
             source: 0,
-            severity: 0,
+            severity: 1,
             details: "Registration Fake Issue details",
           },
         ],
@@ -74,7 +95,7 @@ describe("IssuesDrawer", () => {
             description: "Software Fake Issue",
             kind: "generic",
             source: 0,
-            severity: 0,
+            severity: 1,
             details: "Software Fake Issue details",
           },
         ],
@@ -83,14 +104,14 @@ describe("IssuesDrawer", () => {
             description: "Storage Fake Issue 1",
             kind: "generic",
             source: 0,
-            severity: 0,
+            severity: 1,
             details: "Storage Fake Issue 1 details",
           },
           {
             description: "Storage Fake Issue 2",
             kind: "generic",
             source: 0,
-            severity: 0,
+            severity: 1,
             details: "Storage Fake Issue 2 details",
           },
         ],
@@ -99,7 +120,7 @@ describe("IssuesDrawer", () => {
             description: "Users Fake Issue",
             kind: "generic",
             source: 0,
-            severity: 0,
+            severity: 1,
             details: "Users Fake Issue details",
           },
         ],

web/src/components/core/IssuesDrawer.tsx

@@ -40,7 +40,7 @@ import { _ } from "~/i18n";
  * Drawer for displaying installation issues
  */
 const IssuesDrawer = forwardRef(({ onClose }: { onClose: () => void }, ref) => {
-  const issues = useAllIssues();
+  const issues = useAllIssues().filter((i) => i.severity === IssueSeverity.Error);
   const { phase } = useInstallerStatus({ suspense: true });
   const { issues: issuesByScope } = issues;
 

web/src/types/issues.ts

@@ -85,6 +85,18 @@ class IssuesList {
     };
     this.isEmpty = !Object.values(this.issues).some((v) => v.length > 0);
   }
+
+  /**
+   * Creates a new list only with the issues that match the given function
+   */
+  filter(fn) {
+    return new IssuesList(
+      this.issues["product"].filter(fn),
+      this.issues["software"].filter(fn),
+      this.issues["storage"].filter(fn),
+      this.issues["users"].filter(fn),
+    );
+  }
 }
 
 /**