Skip to content

Two minor visual tweaks at the partitions form #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ancorgs merged 3 commits into from
Feb 24, 2025
Merged

Two minor visual tweaks at the partitions form #2054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0de00e5
web: Add disk size in a selector
ancorgs Feb 24, 2025
28a9cad
web: Reduce excessive space at the partition form
ancorgs Feb 24, 2025
6e68776
web: Changelog
ancorgs Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions web/package/agama-web-ui.changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
-------------------------------------------------------------------
Mon Feb 24 08:50:54 UTC 2025 - Ancor Gonzalez Sosa <ancor@suse.com>

- Some visual changes at the form to add and edit partitions
(gh#agama-project/agama#2054).

-------------------------------------------------------------------
Fri Feb 21 13:56:52 UTC 2025 - José Iván López González <jlopez@suse.com>

Expand Down
23 changes: 13 additions & 10 deletions web/src/components/storage/PartitionPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,8 @@ function TargetOptionLabel({ value }: TargetOptionLabelProps): React.ReactNode {
const device = useDevice();

if (value === NEW_PARTITION) {
return sprintf(_("As a new partition on %s"), device.name);
// TRANSLATORS: %1$s is a disk name (eg. "/dev/sda") and %2$s is its size (eg. "250 GiB")
return sprintf(_("As a new partition on %1$s (%2$s)"), device.name, deviceSize(device.size));
} else {
return sprintf(_("Using partition %s"), value);
}
Expand Down Expand Up @@ -1034,15 +1035,17 @@ function CustomSize({ value, onChange }: CustomSizeProps) {

return (
<Stack hasGutter>
<SubtleContent>
{_("Sizes must be entered as a numbers optionally followed by a unit.")}
</SubtleContent>
<SubtleContent>
{_(
"If the unit is omitted, bytes (B) will be used. Greater units can be of \
the form GiB (power of 2) or GB (power of 10).",
)}
</SubtleContent>
<Stack>
<SubtleContent>
{_("Sizes must be entered as a numbers optionally followed by a unit.")}
</SubtleContent>
<SubtleContent>
{_(
"If the unit is omitted, bytes (B) will be used. Greater units can be of \
the form GiB (power of 2) or GB (power of 10).",
)}
</SubtleContent>
</Stack>
<FormGroup>
<Flex>
<FlexItem>
Expand Down