Conversation
Co-authored-by: David Díaz González <dgonzalez@suse.com> Co-authored-by: Imobach González Sosa <igonzalezsosa@suse.com
* It will be implemented as a Rails application. * The code was generated using the --api and --skip-active-record switches.
* It allows querying and setting properties and calling arbitrary methods of the installer D-Bus interface.
* There is some kind of race condition when using ruby-dbus.
* This approach does not work, as the proxy gets stucked at some point (could it be a ruby-dbus problem?).
jreidinger
reviewed
Dec 23, 2021
| # rspec is known as DSL with big blocks | ||
| Exclude: | ||
| - lib/yast2/dbus/installer.rb | ||
| - yastd/lib/yast2/dbus/installer.rb |
Contributor
There was a problem hiding this comment.
just note that comment is wrong. it is not about rspec, but about dbus DSL
jreidinger
reviewed
Dec 23, 2021
|
|
||
| production: | ||
| adapter: redis | ||
| url: <%= ENV.fetch("REDIS_URL") { "redis://localhost:6379/1" } %> |
Contributor
There was a problem hiding this comment.
why the fetch needs block?
jreidinger
reviewed
Dec 23, 2021
|
|
||
| # Configure sensitive parameters which will be filtered from the log file. | ||
| Rails.application.config.filter_parameters += [ | ||
| :passw, :secret, :token, :_key, :crypt, :salt, :certificate, :otp, :ssn |
Contributor
There was a problem hiding this comment.
nice. Would be nice to have something similar for yast logger
jreidinger
approved these changes
Dec 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yastd-proxyto access the D-Bus service from the browser.