fix(service): better handling of script names#1951
Conversation
5321080 to
2d86bb9
Compare
|
@imobachgs we really mess up with our amount of delayed PR as exactly this fixes I have in my PR #1946 |
|
to be precise I solve it slightly differently, but I have those fixes and also test for it :) |
Yes, I saw it later. Well, the main difference is that in this case I am trying to infer the name of the script from the URL if it is not given. But feel free to close it if you prefer the other way. The only think I do not like about your PR is the "anonymous-" prefix. I would rather prefer something like "script-" or similar. |
|
Well, to reduce the duplication, I am closing this PR. I will review yours. |
|
thanks, change of fallback name is really trivial in mine...lets discuss it there. |
## Problem The conversion of the localization and scripts sections has several problems: - #1903 - #1907 - #1960 This PR include some changes from #1951 and #1946. ## Solution - Fix the handling of the scripts file name and location. - Fix the name of the localization setting ("localization" instead of "l10n"). Additionally, use "pretty" JSON when exporting the converted profile. ## Testing - _Added a new unit test_
Problem
There are a few problems when importing an AutoYaST script:
file_nameinstead offilename.file_nameis missing, it does not propose another name, generating an invalid profile.Solution
Fix both problems by:
filenameinstead offile_name).script-Xwhere
Xis a number.Testing