Conversation
Based on the "agm-show-welcome-screen" flag stored in local storage.
dgdavid
commented
Jan 24, 2025
Contributor
Author
There was a problem hiding this comment.
This still in progress, since there are some drawbacks with the current approach of refreshing the whole interface after requesting the selected language.
- Welcome screen UI cannot react to the selected language for translating the text in the screen and, more important, the main action. Something Agama can live with for the first iteration, though.
- It leads to see too much loader flash (at least four, IIRC) plus an additional flash of the welcome screen, which has to wait until configuration is applied for navigating ahead
- There is also something wrong that makes the installer get stuck in a loader instead of reaching the product selection page.
- From the welcome screen it is (or it shouldn't be) possible to setup the language for the selected product, because there is not a selected product yet. An idea from @imobachgs is to set the language for the product according to the installer settings after selecting the product. However, I think would be nice to be able to send some "default settings" for the product when selecting it instead of waiting after the product selection is finished for requesting something else automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There is not a way for users for easily changing their preferred language even when they know nothing about English.
https://trello.com/c/FS1zHTuL/4061-3-agama-create-a-welcome-screen (protected link)
Solution
To start with a quite simple welcome screen displaying a list of available languages.