Skip to content

fix(service): fix the return value of ListRepositories #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imobachgs merged 2 commits into from
Jan 21, 2025
Merged

fix(service): fix the return value of ListRepositories #1930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
574d8e3
fix(service): fix the return value of ListRepositories
imobachgs Jan 21, 2025
e8e5bc7
docs(service): update the changes file
imobachgs Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions service/lib/agama/dbus/software/manager.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ def issues
# array of repository properties: pkg-bindings ID, alias, name, URL, product dir, enabled
# and loaded flag
dbus_method :ListRepositories, "out Result:a(issssbb)" do
backend.repositories.repositories.map do |repo|
[
[
backend.repositories.repositories.map do |repo|
[
repo.repo_id,
repo.repo_alias,
Expand All @@ -81,8 +81,8 @@ def issues
repo.enabled?,
!!repo.loaded?
]
]
end
end
]
end

# value of result hash is category, description, icon, summary and order
Expand Down
6 changes: 6 additions & 0 deletions service/package/rubygem-agama-yast.changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
-------------------------------------------------------------------
Tue Jan 21 19:11:04 UTC 2025 - Imobach Gonzalez Sosa <igonzalezsosa@suse.com>

- Fix the ListRepositories D-Bus method to return the proper value
instead of crashing the service (gh#agama-project/agama#1930).

-------------------------------------------------------------------
Mon Jan 20 16:44:45 UTC 2025 - Ladislav Slezák <lslezak@suse.com>

Expand Down