Skip to content

fix(web): map product issues to registration path #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgdavid merged 1 commit into from
Jan 9, 2025
Merged

fix(web): map product issues to registration path #1878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion web/src/components/core/IssuesDrawer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,14 @@ describe("IssuesDrawer", () => {
describe("when there are installation issues", () => {
beforeEach(() => {
mockIssuesList = new IssuesList(
[],
[
{
description: "Registration Fake Issue",
source: 0,
severity: 0,
details: "Registration Fake Issue details",
},
],
[
{
description: "Software Fake Issue",
Expand Down Expand Up @@ -97,6 +104,7 @@ describe("IssuesDrawer", () => {
it("renders the drawer with categorized issues linking to their scope", async () => {
const { user } = installerRender(<IssuesDrawer onClose={onCloseFn} />);

const registrationIssues = screen.getByRole("region", { name: "Registration" });
const softwareIssues = screen.getByRole("region", { name: "Software" });
const storageIssues = screen.getByRole("region", { name: "Storage" });
const usersIssues = screen.getByRole("region", { name: "Users" });
Expand All @@ -114,6 +122,14 @@ describe("IssuesDrawer", () => {
expect(usersLink).toHaveAttribute("href", "/users");
within(usersIssues).getByText("Users Fake Issue");

// Regression test: right now, registration issues comes under product
// scope. Check that it links to registration section anyway.
const registrationLink = within(registrationIssues).getByRole("link", {
name: "Registration",
});
expect(registrationLink).toHaveAttribute("href", "/registration");
within(registrationIssues).getByText("Registration Fake Issue");

// onClose should be called when user clicks on a section too for ensuring
// drawer gets closed even when navigation is not needed.
await user.click(usersLink);
Expand Down
3 changes: 2 additions & 1 deletion web/src/components/core/IssuesDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,14 @@ const IssuesDrawer = forwardRef(({ onClose }: { onClose: () => void }, ref) => {
if (issues.length === 0) return null;
// FIXME: address this better or use the /product(s)? namespace instead of
// /registration.
const section = scope === "product" ? "registration" : scope;
const ariaLabelId = `${scope}-issues-section`;

return (
<section key={idx} aria-labelledby={ariaLabelId}>
<Stack hasGutter>
<h4 id={ariaLabelId}>
<Link variant="link" isInline onClick={onClose} to={`/${scope}`}>
<Link variant="link" isInline onClick={onClose} to={`/${section}`}>
{scopeHeaders[scope]}
</Link>
</h4>
Expand Down