Skip to content

fix(web): proper handle of the network prefix #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imobachgs merged 3 commits into from
Nov 5, 2024
Merged

fix(web): proper handle of the network prefix #1728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9be5e7d
fix(web): proper handle of the network prefix
imobachgs Nov 5, 2024
27e2c0b
docs(web): update changes file
imobachgs Nov 5, 2024
32d38bd
Merge branch 'master' into fix-prefix-handling
imobachgs Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion web/package/agama-web-ui.changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
-------------------------------------------------------------------
Mon Nov 04 20:32:29 UTC 2024 - David Diaz <dgonzalez@suse.com>
Tue Nov 5 11:33:12 UTC 2024 - Imobach Gonzalez Sosa <igonzalezsosa@suse.com>

- Fix a crash when editing a network connection containing an
additional IP address (gh#agama-project/agama#1728).

-------------------------------------------------------------------
Mon Nov 4 20:32:29 UTC 2024 - David Diaz <dgonzalez@suse.com>

- Add missing subscription to avoid Agama getting stuck at the installation
progress when the installation finishes
Expand Down
2 changes: 1 addition & 1 deletion web/src/utils/network.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ const isValidIp = (value: IPAddress["address"]) => ipaddr.IPv4.isValidFourPartDe
* @return true if given IP is valid; false otherwise.
*/
const isValidIpPrefix = (value: IPAddress["prefix"]) => {
const prefix = value as string;
const prefix = String(value);

if (prefix.match(/^\d+$/)) {
return parseInt(prefix) <= 32;
Expand Down