-
Notifications
You must be signed in to change notification settings - Fork 74
Separate common files from service rubygem #1677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
14c4381
Hint for rake package invocation
mvidner 9108e2a
packaging: put only ruby-versioned files in the gem
mvidner 2563abf
rpm spec for the files independent of Ruby version
mvidner c3b435e
Build from *.gem instead of from rubygem-*.rpm
mvidner 2891c33
Make agama-yast.spec from spec.in substituting @VERSION@
mvidner d5444a0
remove unneeded shell variable
mvidner a3ae4af
remove from rubygem-*.rpm what goes to agama-yast.rpm
mvidner d9185aa
changelog
mvidner 7640286
runtime dependency between the split packages
mvidner 455c213
don't provide the name that became a regular package
mvidner a470551
install also the new package
mvidner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| *.gem | ||
| # the spec file is generated | ||
| /package/*.spec | ||
| /package/rubygem*.spec | ||
| *.rbc | ||
| /.config | ||
| /coverage/ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| # | ||
| # spec file for package agama-yast | ||
| # | ||
| # Copyright (c) 2024 SUSE LLC | ||
| # | ||
| # All modifications and additions to the file contributed by third parties | ||
| # remain the property of their copyright owners, unless otherwise agreed | ||
| # upon. The license for this file, and modifications and additions to the | ||
| # file, is the same license as for the pristine package itself (unless the | ||
| # license for the pristine package is not an Open Source License, in which | ||
| # case the license is the MIT License). An "Open Source License" is a | ||
| # license that conforms to the Open Source Definition (Version 1.9) | ||
| # published by the Open Source Initiative. | ||
|
|
||
| # Please submit bugfixes or comments via https://bugs.opensuse.org/ | ||
| # | ||
|
|
||
|
|
||
| Name: agama-yast | ||
| Version: @VERSION@ | ||
| Release: 0 | ||
| %define mod_name agama-yast | ||
| %define mod_full_name %{mod_name}-%{version} | ||
| BuildRequires: dbus-1-common | ||
| # "msgfmt" tool | ||
| BuildRequires: gettext-runtime | ||
| Requires: dbus-1-common | ||
| Requires: rubygem(agama-yast) | ||
|
|
||
| BuildRoot: %{_tmppath}/%{name}-%{version}-build | ||
| BuildRequires: ruby-macros >= 5 | ||
|
|
||
| URL: https://github.com/openSUSE/agama | ||
| Source: %{mod_full_name}.gem | ||
| Source1: po.tar.bz2 | ||
| Source2: install_translations.sh | ||
| Summary: YaST integration service for Agama - common files | ||
| License: GPL-2.0-only | ||
| Group: Development/Languages/Ruby | ||
|
|
||
| %description | ||
| D-Bus service exposing some YaST features that are useful for Agama. | ||
|
|
||
| %prep | ||
| %{gem_unpack} | ||
|
|
||
| %build | ||
|
|
||
| %install | ||
| install -D -m 0644 %{mod_full_name}/share/dbus.conf %{buildroot}%{_datadir}/dbus-1/agama.conf | ||
| install --directory %{buildroot}%{_datadir}/dbus-1/agama-services | ||
| install -m 0644 --target-directory=%{buildroot}%{_datadir}/dbus-1/agama-services %{mod_full_name}/share/org.opensuse.Agama*.service | ||
| install -D -m 0644 %{mod_full_name}/share/agama.service %{buildroot}%{_unitdir}/agama.service | ||
| install -D -m 0644 %{mod_full_name}/share/agama-proxy-setup.service %{buildroot}%{_unitdir}/agama-proxy-setup.service | ||
| install --directory %{buildroot}/usr/share/agama/conf.d | ||
| install -D -m 0644 %{mod_full_name}/conf.d/*.yaml %{buildroot}/usr/share/agama/conf.d/ | ||
|
|
||
| # run a script for installing the translations | ||
| sh "%{SOURCE2}" "%{SOURCE1}" | ||
|
|
||
| %pre | ||
| %service_add_pre agama.service | ||
|
|
||
| %post | ||
| %service_add_post agama.service | ||
|
|
||
| %preun | ||
| %service_del_preun agama.service | ||
|
|
||
| %postun | ||
| %service_del_postun_with_restart agama.service | ||
|
|
||
| %files | ||
| %{_datadir}/dbus-1/agama.conf | ||
| %dir %{_datadir}/dbus-1/agama-services | ||
| %{_datadir}/dbus-1/agama-services/org.opensuse.Agama*.service | ||
| %{_unitdir}/agama.service | ||
| %{_unitdir}/agama-proxy-setup.service | ||
| %dir %{_datadir}/agama | ||
| %dir %{_datadir}/agama/conf.d | ||
| %{_datadir}/agama/conf.d | ||
| %dir /usr/share/YaST2 | ||
| /usr/share/YaST2/locale | ||
|
|
||
| %changelog |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it still required here for gem or only needed for new package with files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Also, I will need to make the new package require the older one