Skip to content

fix(service): Fixed shell injection vulnerability in the internal API #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lslezak merged 2 commits into from
Oct 14, 2024
Merged

fix(service): Fixed shell injection vulnerability in the internal API #1668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02a3b71
Fixed shell injection vulnerability in the internal API
lslezak Oct 14, 2024
c268922
Changes
lslezak Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion service/lib/agama/manager.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
# To contact SUSE LLC about this file by physical or electronic mail, you may
# find current contact information at www.suse.com.

require "shellwords"

require "yast"
require "agama/config"
require "agama/network"
Expand Down Expand Up @@ -236,7 +238,7 @@ def valid?
#
# @return [String] path to created archive
def collect_logs(path: nil)
opt = "-d #{path}" unless path.nil? || path.empty?
opt = "-d #{path.shellescape}" unless path.nil? || path.empty?

`agama logs store #{opt}`.strip
end
Expand Down
6 changes: 6 additions & 0 deletions service/package/rubygem-agama-yast.changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
-------------------------------------------------------------------
Mon Oct 14 14:52:26 UTC 2024 - Ladislav Slezák <lslezak@suse.com>

- Fixed shell injection vulnerability in the internal API
(gh#agama-project/agama#1668)

-------------------------------------------------------------------
Tue Oct 8 12:25:08 UTC 2024 - Ancor Gonzalez Sosa <ancor@suse.com>

Expand Down