Skip to content

fix(web): wrap the application in a <Suspense/> component #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imobachgs merged 2 commits into from
Oct 3, 2024
Merged

fix(web): wrap the application in a <Suspense/> component #1654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95d4349
fix(web): wrap the application in a <Suspense/> component
imobachgs Oct 3, 2024
d00b304
doc(web): update changes file
imobachgs Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion web/package/agama-web-ui.changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
-------------------------------------------------------------------
Thu Oct 3 10:20:34 UTC 2024 - Imobach Gonzalez Sosa <igonzalezsosa@suse.com>

- Drop the old HTTPClient (gh#agama-project/agama#1639).

-------------------------------------------------------------------
Mon Sep 30 08:52:36 UTC 2024 - Imobach Gonzalez Sosa <igonzalezsosa@suse.com>

Expand All @@ -14,7 +19,7 @@ Fri Sep 27 13:00:05 UTC 2024 - Imobach Gonzalez Sosa <igonzalezsosa@suse.com>

- Properly translate the storage interface when switching
the language of the UI (gh#agama-project/agama#1629).

-------------------------------------------------------------------
Mon Sep 23 09:04:56 UTC 2024 - Knut Anderssen <kanderssen@suse.com>

Expand Down
9 changes: 7 additions & 2 deletions web/src/context/root.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@

// @ts-check

import React from "react";
import React, { Suspense } from "react";
import { AuthProvider } from "./auth";
import { Loading } from "~/components/layout";

/**
* Combines all application providers.
Expand All @@ -32,7 +33,11 @@ import { AuthProvider } from "./auth";
* @param {React.ReactNode} [props.children] - content to display within the provider.
*/
function RootProviders({ children }) {
return <AuthProvider>{children}</AuthProvider>;
return (
<Suspense fallback={<Loading />}>
<AuthProvider>{children}</AuthProvider>
</Suspense>
);
}

export { RootProviders };