Skip to content

fix(web): display the installation progress when connecting late #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgdavid merged 3 commits into from
Jun 26, 2024
Merged

fix(web): display the installation progress when connecting late #1394

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9af4384
fix(web): display the installation progress when connecting late
imobachgs Jun 26, 2024
294b82f
doc(web): update the changes file
imobachgs Jun 26, 2024
0ae8266
fix: update from code review
imobachgs Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions web/package/agama-web-ui.changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
-------------------------------------------------------------------
Wed Jun 26 15:57:52 UTC 2024 - Imobach Gonzalez Sosa <igonzalezsosa@suse.com>

- Display the installation progress when connecting in the middle
of the process (gh#openSUSE/agama#1394).

-------------------------------------------------------------------
Wed Jun 26 14:17:30 UTC 2024 - David Diaz <dgonzalez@suse.com>

Expand Down
11 changes: 2 additions & 9 deletions web/src/components/core/InstallationProgress.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,14 @@
*/

import React from "react";
import { useProduct } from "~/context/product";
import { sprintf } from "sprintf-js";
import { _ } from "~/i18n";
import ProgressReport from "./ProgressReport";
import SimpleLayout from "~/SimpleLayout";

function InstallationProgress() {
const { selectedProduct } = useProduct();
console.log("INSTALATION ISSUE");

@dgdavid dgdavid Jun 26, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed?

@imobachgs imobachgs Jun 26, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch, fixed


if (!selectedProduct) {
return;
}

// TRANSLATORS: %s is replaced by a product name (e.g., openSUSE Tumbleweed)
const title = sprintf(_("Installing %s, please wait ..."), selectedProduct.name);
const title = _("Installing the system, please wait ...");
return (
<SimpleLayout showOutlet={false}>
<ProgressReport title={title} />
Expand Down